Skip to content

chore: move FadeInSlideOut into Animation folder & write story #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

chore: move FadeInSlideOut into Animation folder & write story #3082

wants to merge 24 commits into from

Conversation

nhivpham
Copy link

@nhivpham nhivpham commented May 13, 2025 •
edited
Loading

Overview

Moves FadeInSlideOut animation component from /Motion directory into /Animation. Additionally, adds a story page for FadeInSlideOut.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GM-1107
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Visit the FadeInSlideOut animation
  2. View FadeInSlideOut docs
  3. Click click about, test the "Click Me." button
  4. Visit the FadeInSlideOut docs
  5. Click click about, test the "Click Me." button
  6. Profit!

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@CLAassistant
Copy link

CLAassistant commented May 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 13, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a8a99c9

Command Status Duration Result
nx run-many --target=build --all ✅ Succeeded 18s View ↗
nx run-many --target=verify --parallel=3 --all ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-23 20:03:25 UTC

@nhivpham nhivpham changed the title Np gm 1107 chore: move FadeInSlideOut into Animation folder & write story May 13, 2025
@nhivpham nhivpham marked this pull request as ready for review September 9, 2025 08:01
@nhivpham nhivpham requested a review from a team as a code owner September 9, 2025 08:01
jakemhiller
jakemhiller reviewed Sep 9, 2025
View reviewed changes
packages/styleguide/src/lib/Atoms/Animations/FadeInSlideOut/FadeInSlideOut.stories.tsx Outdated
{isVisible ? 'Thanks!' : 'Click me.'}
</FillButton>
</Box>
<Box mt={8}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to give this a fixed height. I noticed that the animation is a little chunky in storybook because it's recalculating the height at the same time. Something to be aware of when we use it i guess too, but it may just be an issue with the storybook layout.

jakemhiller
jakemhiller approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://68d2fe1cf68d31526eac3dd6--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@LinKCoding LinKCoding Awaiting requested review from LinKCoding LinKCoding is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nhivpham @CLAassistant @codecademydev @jakemhiller